Uploaded image for project: 'Spring AMQP'
  1. Spring AMQP
  2. AMQP-760

Add the encoder support for rabbit.logback.AmqpAppender

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Complete
    • Affects Version/s: 1.7.3
    • Fix Version/s: 2.0 RC1
    • Component/s: RabbitMQ
    • Labels:

      Description

      Hi Guys,

      thanks for help me answer my question.

      i found most appender are support the encoder tag, but the amqp doesn't support the tag, i think if rabbit appender can support the encoder tag, that's would be great.

      thanks in advance!

        Activity

        Hide
        abilan Artem Bilan added a comment -

        There is nothing to stop you to Contribute the feature!

        Show
        abilan Artem Bilan added a comment - There is nothing to stop you to Contribute the feature!
        Hide
        Nicolas Ristock Nicolas Ristock added a comment -

        I started working on this today and realized that there are a couple of points which we should either talk about or require clarification.

        • From my understanding you should either have an encoder or a layout but having both doesn't make much sense. Though, to keep backward-compatibility the AmqpAppender needs to support both. What is the expected behavior if a user specifies both - a layout and an encoder? I suppose we could either have the encoder take precedence over the layout or fail with a "you can't have both" type of error similar to what is already done when no layout is specified.
        • I'm not that familiar with Log4J 2 - do they have an equivalent feature or does their "Layout" already cover Logback's encoder functionality?
        Show
        Nicolas Ristock Nicolas Ristock added a comment - I started working on this today and realized that there are a couple of points which we should either talk about or require clarification. From my understanding you should either have an encoder or a layout but having both doesn't make much sense. Though, to keep backward-compatibility the AmqpAppender needs to support both. What is the expected behavior if a user specifies both - a layout and an encoder? I suppose we could either have the encoder take precedence over the layout or fail with a "you can't have both" type of error similar to what is already done when no layout is specified. I'm not that familiar with Log4J 2 - do they have an equivalent feature or does their "Layout" already cover Logback's encoder functionality?
        Hide
        grussell Gary Russell added a comment -

        Nicolas Ristock Thanks for working on this.

        • I would say we can safely fail if both are provided
        • I don't think there's an equivalent in Log4j2, so just ignore that appender.
        Show
        grussell Gary Russell added a comment - Nicolas Ristock Thanks for working on this. I would say we can safely fail if both are provided I don't think there's an equivalent in Log4j2, so just ignore that appender.

          People

          • Assignee:
            abilan Artem Bilan
            Reporter:
            minchina91 maoningchuan
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: