Spring Batch
  1. Spring Batch
  2. BATCH-1213

Defaults in xsd override parent attributes

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.0.1
    • Component/s: Core
    • Labels:
      None

      Description

      Some attributes in the xsd have defaults. For example: transactionManager and jobRepository. However, if a non-default value is set on a parent step, but not re-set on an extending bean, then attribute on the extending bean will be overridden by the default.

      Therefore, for elements that allow "parents", defaults should be removed from the xsd and the parser. The defaulting should happen in the FactoryBean, because it is at this time that the framework can see if the value was ever set.

        Activity

        Hide
        Dave Syer added a comment -

        I tidied up the BeanDefinition handling a bit (re-used core utils where possible) and used AttributeAccessor instead of PropertyValues to stash the temporary reference to the JobRepository.

        Show
        Dave Syer added a comment - I tidied up the BeanDefinition handling a bit (re-used core utils where possible) and used AttributeAccessor instead of PropertyValues to stash the temporary reference to the JobRepository.

          People

          • Assignee:
            Dan Garrette
            Reporter:
            Dan Garrette
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 0.25d
              0.25d
              Remaining:
              Remaining Estimate - 0.25d
              0.25d
              Logged:
              Time Spent - Not Specified
              Not Specified