Spring Batch
  1. Spring Batch
  2. BATCH-1412

Allow a Job to accept JobParameters that do not contribute to its identity

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Complete
    • Affects Version/s: None
    • Fix Version/s: 2.2.0, 2.2.0 - Sprint 14
    • Component/s: Core
    • Labels:
      None

      Description

      There is a question of whether JobParameters are the right vehicle for this since they are so intimately connected with identity, but the business use case is clear (see some relevant discussion in http://forum.springsource.org/showthread.php?t=74191).

        Activity

        Hide
        Michael Minella added a comment -

        Adrian, it is our intent to implement JSR-352 as part of the Spring Batch 3.0 release.

        Show
        Michael Minella added a comment - Adrian, it is our intent to implement JSR-352 as part of the Spring Batch 3.0 release.
        Hide
        David Victor added a comment -

        It looks to me like it isn't too huge a change for migrating users....

        2.2.0/BATCH-1412 breaks part of our app. Whilst I don't doubt the justification of the refactoring, just some feedback from the sharp end. I'm sure we can rework our code in a couple of days, but right now & potentially for some time we can't justify this as part of moving to 2.2.0

        Show
        David Victor added a comment - It looks to me like it isn't too huge a change for migrating users.... 2.2.0/ BATCH-1412 breaks part of our app. Whilst I don't doubt the justification of the refactoring, just some feedback from the sharp end . I'm sure we can rework our code in a couple of days, but right now & potentially for some time we can't justify this as part of moving to 2.2.0
        Hide
        Dave Syer added a comment -

        Thanks for the feedback. It would be more useful if you had said how exactly your app is broken (stacktrace, compile error etc.).

        Show
        Dave Syer added a comment - Thanks for the feedback. It would be more useful if you had said how exactly your app is broken (stacktrace, compile error etc.).
        Hide
        David Victor added a comment -

        Apologies for delay. Didn't have time to look into it.

        • Compilation errors, due to moving job params from the instance to the execution - no big deal
        • Was getting runtime errors from Spring Batch Admin for pre 2.2. jobs, but adding BATCH_JOB_EXECUTION_PARAMS resolved this, - not really an issue.
        • Need to refactor an internal component - can't go into too much detail for confidentiality reasons - due to job params relocating to execution. Need to locate Spring Batch meta-data by date range for a cleanup task. A day or two's work - but will need to be planned in for us to move to 2.2

        So as said, it isn't a "huge" change.

        Assume the Spring Batch Admin 1.3 release will align with 2.2.

        Show
        David Victor added a comment - Apologies for delay. Didn't have time to look into it. Compilation errors, due to moving job params from the instance to the execution - no big deal Was getting runtime errors from Spring Batch Admin for pre 2.2. jobs, but adding BATCH_JOB_EXECUTION_PARAMS resolved this, - not really an issue. Need to refactor an internal component - can't go into too much detail for confidentiality reasons - due to job params relocating to execution . Need to locate Spring Batch meta-data by date range for a cleanup task. A day or two's work - but will need to be planned in for us to move to 2.2 So as said, it isn't a "huge" change. Assume the Spring Batch Admin 1.3 release will align with 2.2.
        Hide
        Michael Minella added a comment -

        David Victor, Thanks for the feedback. You are correct in that the next release of Admin will address the issues that 2.2.0 causes.

        Show
        Michael Minella added a comment - David Victor , Thanks for the feedback. You are correct in that the next release of Admin will address the issues that 2.2.0 causes.

          People

          • Assignee:
            Michael Minella
            Reporter:
            Dave Syer
          • Votes:
            2 Vote for this issue
            Watchers:
            11 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 0.25d
              0.25d
              Remaining:
              Remaining Estimate - 0.25d
              0.25d
              Logged:
              Time Spent - Not Specified
              Not Specified