Uploaded image for project: 'Spring Batch'
  1. Spring Batch
  2. BATCH-1815

RunIdIncrementer goes against java best practices

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.8
    • Fix Version/s: 2.1.9
    • Component/s: Core
    • Labels:
      None

      Description

      public JobParameters getNext(JobParameters parameters) {
      if (parameters == null)

      { parameters = new JobParameters(); }

      The above code is leading to blocking issues in our sonar build (we have code which was copied from this JobParametersIncrementer). It is a general consensus that you shouldn't reassign method parameters.

        Attachments

          Activity

            People

            • Assignee:
              robert.kasanicky Robert Kasanicky
              Reporter:
              mdeinum Marten Deinum
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: