Spring Batch
  1. Spring Batch
  2. BATCH-773

Refactor and extend ExportedJobLauncher to JobOperator

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0.M1
    • Fix Version/s: 2.0.0.M2
    • Component/s: Core
    • Labels:
      None

      Issue Links

        Activity

        Hide
        Dave Syer added a comment -

        N.B. had to use long (not Long) in interface params (http://bugs.sun.com/view_bug.do?bug_id=6704904) so that JConsole can invoke those methods.

        Show
        Dave Syer added a comment - N.B. had to use long (not Long) in interface params ( http://bugs.sun.com/view_bug.do?bug_id=6704904 ) so that JConsole can invoke those methods.
        Hide
        Dave Syer added a comment -

        All finished except the stop() method which needs BATCH-453 to be fixed first.

        Show
        Dave Syer added a comment - All finished except the stop() method which needs BATCH-453 to be fixed first.
        Hide
        Lucas Ward added a comment -

        Dave,

        I looked through the code for this today in detail. For the most part, the methods look fine, and I think any major methods we miss can be added, or existing ones tweaked over the next few months. The one thing that seems missing is pulling back the step execution information with it. Isn't having a running JobExecution useless without it's StepExecution (that's actually running?) I would expect when using the interface that a JobExecution that is listed as running would have all the StepExecutions with it, or at least some way to get the information separately.

        I keep going back and forth on the interfaces and implementations, in some ways I like it, in others I don't, but in thinking on it again, I might be okay with it, etc. I think I just need to build an actual client against these interfaces to see how it stacks up. (I suppose you're already doing some of the same via JConsole)

        I can take a crack at BATCH-453 tomorrow as well.

        Show
        Lucas Ward added a comment - Dave, I looked through the code for this today in detail. For the most part, the methods look fine, and I think any major methods we miss can be added, or existing ones tweaked over the next few months. The one thing that seems missing is pulling back the step execution information with it. Isn't having a running JobExecution useless without it's StepExecution (that's actually running?) I would expect when using the interface that a JobExecution that is listed as running would have all the StepExecutions with it, or at least some way to get the information separately. I keep going back and forth on the interfaces and implementations, in some ways I like it, in others I don't, but in thinking on it again, I might be okay with it, etc. I think I just need to build an actual client against these interfaces to see how it stacks up. (I suppose you're already doing some of the same via JConsole) I can take a crack at BATCH-453 tomorrow as well.
        Hide
        Dave Syer added a comment -

        Step execution info is provided by Map<Long, String> getStepExecutionSummaries(long executionId). You see from that all the step executions associated with a job execution (more than one might be running). Isn't that what you need? I can't test the whole thing in JConsole yet because of BATCH-453 (but it's assigned to Thomas and I am happy to wait for him, so don't start on that unless you really want to).

        Show
        Dave Syer added a comment - Step execution info is provided by Map<Long, String> getStepExecutionSummaries(long executionId). You see from that all the step executions associated with a job execution (more than one might be running). Isn't that what you need? I can't test the whole thing in JConsole yet because of BATCH-453 (but it's assigned to Thomas and I am happy to wait for him, so don't start on that unless you really want to).
        Hide
        Dave Syer added a comment -

        Assigned for review. N.B. there is an issue outstanding issue (BATCH-834) to add a new related feature.

        Show
        Dave Syer added a comment - Assigned for review. N.B. there is an issue outstanding issue ( BATCH-834 ) to add a new related feature.

          People

          • Assignee:
            Thomas Risberg
            Reporter:
            Dave Syer
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1d 1h Original Estimate - 1d 1h
              1d 1h
              Remaining:
              Time Spent - 2d 1h Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - 2d 1h Remaining Estimate - 1h
              2d 1h