Uploaded image for project: 'Spring Data Commons'
  1. Spring Data Commons
  2. DATACMNS-1236

Inconsistent nullability constraints in PageImpl Javadoc

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.2 (Kay SR2)
    • Component/s: None
    • Labels:
      None

      Description

      In class "org.springframework.data.domain.PageImpl", the field "pageable" is considered as nullable :

      the paging information, can be {@literal null}.
      

      But the super class org.springframework.data.domain.Chunk, owns the same field, same name and considered as not null :

      pageable must not be {@literal null}.
      ...
      Assert.notNull(pageable, "Pageable must not be null!");
      

      Two issues :

      • Duplicate field -> either use the getter from Chunk#getPageable(), either make it protected
      • Make not Null the constructor "pageable" parameter of PageImpl

        Attachments

          Activity

            People

            Assignee:
            mp911de Mark Paluch
            Reporter:
            fabdouglas Fabrice Daugan
            Last updater:
            Mark Paluch
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: