Uploaded image for project: 'Spring Data Commons'
  1. Spring Data Commons
  2. DATACMNS-1706

PreferredConstructor needs to improve bottleneck occurrence.

    XMLWordPrintable

    Details

      Description

      Bottleneck occurs when  there are many concurrent calls to "isConstructorParameter" in  "PreferredConstructor".

      I have found that using Spring Data JDBC, the bottleneck occurs when there are many concurrent requests in "BasicJdbcConverter".

      https://github.com/spring-projects/spring-data-jdbc/blob/c0803ddafef7a4bc4ec070df6581d46c4d59ff4a/spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/BasicJdbcConverter.java#L400

       

      It is expected to be improved by changing the lock of "PreferredConstructor#isConsturctorParameter" to  "ConcurrentHashMap".
      It is expected to be improved by changing the lock of "PreferredConstructor # isConstructorParameter" to ConcurrentHashMap.
      https://github.com/spring-projects/spring-data-commons/blob/master/src/main/java/org/springframework/data/mapping/PreferredConstructor.java#L134

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mp911de Mark Paluch
              Reporter:
              myeonghyeonLee MyeongHyeonLee
              Last updater:
              MyeongHyeonLee
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: