Spring Data Neo4j
  1. Spring Data Neo4j
  2. DATAGRAPH-280

Support for AspectJ 1.7.0 / AJDT 2.20 / Eclipse 4.2 Juno

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Complete
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.1
    • Component/s: None
    • Labels:
    • Environment:
      Arch Linux x64, Maven 3, JDK1.7

      Activity

      Hide
      Johannes Mockenhaupt added a comment -

      (Sorry for screwing up the description).

      When compiling SDN against AspectJ 1.7.0 the errors below occur. It would be nice if SDN would support AspectJ 1.7.0, as Eclipse 4.2 uses AJDT 2.2.0, which in turn uses AspectJ 1.7.0. Hence the errors below, reported by maven, are flagged as errors by Eclipse as well.

      [INFO] — aspectj-maven-plugin:1.2:test-compile (test-compile) @ spring-data-neo4j-aspects —
      [ERROR] The type org.springframework.data.neo4j.aspects.Group must implement the inherited abstract method org.springframework.data.neo4j.aspects.core.NodeBacked.relateTo(Lorg/springframework/data/neo4j/aspects/core/NodeBacked;Ljava/lang/Class;Ljava/lang/String
      [ERROR] The type org.springframework.data.neo4j.aspects.Group must implement the inherited abstract method org.springframework.data.neo4j.aspects.core.NodeBacked.relateTo(Lorg/springframework/data/neo4j/aspects/core/NodeBacked;Ljava/lang/Class;Ljava/lang/String;Z)

      Show
      Johannes Mockenhaupt added a comment - (Sorry for screwing up the description). When compiling SDN against AspectJ 1.7.0 the errors below occur. It would be nice if SDN would support AspectJ 1.7.0, as Eclipse 4.2 uses AJDT 2.2.0, which in turn uses AspectJ 1.7.0. Hence the errors below, reported by maven, are flagged as errors by Eclipse as well. [INFO] — aspectj-maven-plugin:1.2:test-compile (test-compile) @ spring-data-neo4j-aspects — [ERROR] The type org.springframework.data.neo4j.aspects.Group must implement the inherited abstract method org.springframework.data.neo4j.aspects.core.NodeBacked.relateTo(Lorg/springframework/data/neo4j/aspects/core/NodeBacked;Ljava/lang/Class;Ljava/lang/String [ERROR] The type org.springframework.data.neo4j.aspects.Group must implement the inherited abstract method org.springframework.data.neo4j.aspects.core.NodeBacked.relateTo(Lorg/springframework/data/neo4j/aspects/core/NodeBacked;Ljava/lang/Class;Ljava/lang/String;Z)
      Hide
      Andy Clement added a comment -

      This problem is raised against AspectJ as https://bugs.eclipse.org/bugs/show_bug.cgi?id=386888 - that bug has just been fixed and fixes are available in 1.7.1 build snapshots (1.7.1.BUILD-SNAPSHOT from the maven spring snapshots repo). I am currently trying to get it into AJDT dev builds but my git push is timing out (damn thing!) - it should be in AJDT in a couple of days.

      Show
      Andy Clement added a comment - This problem is raised against AspectJ as https://bugs.eclipse.org/bugs/show_bug.cgi?id=386888 - that bug has just been fixed and fixes are available in 1.7.1 build snapshots (1.7.1.BUILD-SNAPSHOT from the maven spring snapshots repo). I am currently trying to get it into AJDT dev builds but my git push is timing out (damn thing!) - it should be in AJDT in a couple of days.
      Hide
      Andy Clement added a comment -

      This should now be addressed in AspectJ 1.7.1 (bug 386888 is fixed) which is packaged inside AJDT 2.2.1 dev builds. Those dev builds are available at this update site (for eclipse 4.2): http://download.eclipse.org/tools/ajdt/42/dev/update

      I just tried out the hello-worlds sample and it failed with the default AJDT (with the errors above), I then upgraded my AJDT to the dev build and it then compiled clean.

      Hopefully STS 3.1 will include AJDT 2.2.1 (AspectJ 1.7.1)

      Show
      Andy Clement added a comment - This should now be addressed in AspectJ 1.7.1 (bug 386888 is fixed) which is packaged inside AJDT 2.2.1 dev builds. Those dev builds are available at this update site (for eclipse 4.2): http://download.eclipse.org/tools/ajdt/42/dev/update I just tried out the hello-worlds sample and it failed with the default AJDT (with the errors above), I then upgraded my AJDT to the dev build and it then compiled clean. Hopefully STS 3.1 will include AJDT 2.2.1 (AspectJ 1.7.1)
      Hide
      Johannes Mockenhaupt added a comment -

      Thanks Andy, it's fixed for me too. I made a pull request that updates the docs accordingly (https://github.com/SpringSource/spring-data-neo4j/pull/83).

      Show
      Johannes Mockenhaupt added a comment - Thanks Andy, it's fixed for me too. I made a pull request that updates the docs accordingly ( https://github.com/SpringSource/spring-data-neo4j/pull/83 ).
      Hide
      Michael Hunger added a comment -

      Thanks Andy & Johannes.

      Merged the PR.

      Michael

      Show
      Michael Hunger added a comment - Thanks Andy & Johannes. Merged the PR. Michael

        People

        • Assignee:
          Michael Hunger
          Reporter:
          Johannes Mockenhaupt
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved: