Uploaded image for project: 'Spring Data Redis'
  1. Spring Data Redis
  2. DATAREDIS-1173

Close connection unsubscribes from all channels incorrectly using Lettuce

    XMLWordPrintable

    Details

      Description

      The LettuceSubscription doClose method calls doUnsubscribe with an empty byte array, which results in a call to Redis of:

      UNSUBSCRIBE ""

      This command will unsubscribe from a channel with the name ""  However, we believe the intended behavior is to unsubscribe from all channels, which can be done by not sending any argument to doUnsubscribe, resulting in a call to Redis of:

      UNSUBSCRIBE
      

      We wrote a failing and passing test showing the problem.  We could not find a way to expose the issue by calling doClose on the subscription (because doClose also releases the connection), so we had to call unsubscribe directly.  We are not sure where this belongs in your testing pyramid.

        Attachments

          Activity

            People

            Assignee:
            mp911de Mark Paluch
            Reporter:
            sabbeypivotal sabbeyPivotal
            Last updater:
            Mark Paluch
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: