Uploaded image for project: 'Spring Data Redis'
  1. Spring Data Redis
  2. DATAREDIS-535

Spring Data Rest Should delegate compatibility checking to Jedis

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Works as Designed
    • Affects Version/s: 1.7.2 (Hopper SR2)
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      Currently, there is code (lines 298-300 of JedisConnectionFactory on Master as of 07/18/16), that checks to see whether or not someone is using a password for a redis cluster, and if they are, it throws an exception stating that jedis does not support password protected Redis Cluster Configurations. However, since jedis does now support passwords on clusters (on master and the 2.9 branch, neither of which are released yet), even if I build jedis from source and add the new dependency into my project, I still can't access that new feature. In my opinion, deprecated/unsupported operations should be delegated to the underlying library, as it now creates the following situation where someone could build jedis from source, and be blocked from using it, unless they modify the spring-data-redis code and custom deploy both softwares. The only real fix (now) would be to wait until jedis releases an official version, and then you have a dependency of the latest version of jedis on your next release, so people can't use an older version of jedis that didn't support cluster passwords.

      Anyway, it really seems like the wrong approach to define feature availability at the spring level, especially when it's essentially a wrapper on top of jedis, since it requires you to always stay on top of the newest features in these libraries pretty much all the time, with fast update responses to any features they add.

        Attachments

          Activity

            People

            • Assignee:
              mp911de Mark Paluch
              Reporter:
              wdaniels William Daniels
              Last updater:
              Mark Paluch
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: