Spring Integration
  1. Spring Integration
  2. INT-1921

INT-1885 causes the default remote-file-separator to be initialized to an empty string, rather than the previous default of "/"

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Complete
    • Affects Version/s: 2.0.4
    • Fix Version/s: 2.0.5
    • Component/s: File Support
    • Labels:
      None
    • Environment:
      Any

      Description

      Up to Spring Integration 2.0.3, not specifying a remote-file-separator for inbound SFTP/FTP adapters would set a default value of "/". In 2.0.4, the implicit default accidentally changed to "".

        Activity

        Hide
        Mark Fisher added a comment -

        There are 2 options here. One is to use element.hasAttribute() in order to distinguish between nothing being provided and the end-user configuring just an empty string (see INT-1885). The other option is to define / as the "default" in the XML schema as well (which has the advantage of being self-documenting). In either case, the default "/" should remain in the underlying class - it's just that currently that value is always being overridden since getAttribute() never returns null.

        Show
        Mark Fisher added a comment - There are 2 options here. One is to use element.hasAttribute() in order to distinguish between nothing being provided and the end-user configuring just an empty string (see INT-1885 ). The other option is to define / as the "default" in the XML schema as well (which has the advantage of being self-documenting). In either case, the default "/" should remain in the underlying class - it's just that currently that value is always being overridden since getAttribute() never returns null.
        Hide
        Pavel Tcholakov added a comment -

        I quite like the idea of adding it to the XSD - as long as the default is "/" in the Java source code as well as you say.

        Show
        Pavel Tcholakov added a comment - I quite like the idea of adding it to the XSD - as long as the default is "/" in the Java source code as well as you say.
        Hide
        Oleg Zhurakousky added a comment -

        Fixed. The '/' was added as a default to the schema of both FTP and SFTP.

        Show
        Oleg Zhurakousky added a comment - Fixed. The '/' was added as a default to the schema of both FTP and SFTP.

          People

          • Assignee:
            Oleg Zhurakousky
            Reporter:
            Pavel Tcholakov
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 0.5h
              0.5h
              Remaining:
              Remaining Estimate - 0.5h
              0.5h
              Logged:
              Time Spent - Not Specified
              Not Specified