Spring Integration
  1. Spring Integration
  2. INT-2254

Detect if the payload is already a message in HttpRequestHandlingEndpointSupport

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Complete
    • Affects Version/s: 2.0.5
    • Fix Version/s: 2.0.6, 2.1 RC1
    • Component/s: Async HTTP Support
    • Labels:
      None

      Description

      The HttpRequestHandlingEndpointSupport does not detect if the payload received in the HTTP request body is an instance of Message<?>. This will be the case when the client sent the message using the SerializingHttpMessageConverter. The HttpRequestHandlingEndpointSupport will correctly used the SerializingHttpMessageConverter to read the HTTP request, but then attempts to convert that into a message using a MessageBuilder. It should just use the message as is, perhaps with an option to merge HTTP headers with the message headers.

        Activity

        Show
        Oleg Zhurakousky added a comment - PR is issued https://github.com/SpringSource/spring-integration/pull/195
        Hide
        Oleg Zhurakousky added a comment -

        As you can see form the PR we are now relying on the builder building a new Message from the retrieved Message.
        Let me know if you had something else in mind

        Show
        Oleg Zhurakousky added a comment - As you can see form the PR we are now relying on the builder building a new Message from the retrieved Message. Let me know if you had something else in mind
        Hide
        Mark Fisher added a comment -

        Also see my comments in the PR regarding the headers. You mentioned above that you would like the option of merging HTTP headers, but I think this should be handled adequately by the existing behavior in our HeaderMapper since you do have full control over what gets mapped (including nothing if you prefer) by including the 'mapped-request-headers' attribute in the configuration.

        Show
        Mark Fisher added a comment - Also see my comments in the PR regarding the headers. You mentioned above that you would like the option of merging HTTP headers, but I think this should be handled adequately by the existing behavior in our HeaderMapper since you do have full control over what gets mapped (including nothing if you prefer) by including the 'mapped-request-headers' attribute in the configuration.
        Hide
        Mark Fisher added a comment -

        Reopening while we backport to 'maint' for the upcoming 2.0.6 release.

        Show
        Mark Fisher added a comment - Reopening while we backport to 'maint' for the upcoming 2.0.6 release.

          People

          • Assignee:
            Oleg Zhurakousky
            Reporter:
            Don Laidlaw
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: