Spring Integration
  1. Spring Integration
  2. INT-2920

Claim Check Out calls both MessageStore.getMessage and MessageStore.removeMessage when removing

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Complete
    • Affects Version/s: 2.2. GA
    • Fix Version/s: 3.0 M1, 2.2.2
    • Component/s: Core
    • Labels:

      Description

      When ClaimCheckOutTransformer is asked to remove a message when retrieving it, it uses both MessageStore.getMessage and MessageStore.removeMessage, although MessageStore.removeMessage is supposed to return the message as well.

      It ends up, for JdbcMessageStore anyways, retrieving the row twice (and performing the row mapping twice). For large payloads, this deserialization might take some time.

        Activity

        Hide
        Nick Spacek added a comment -

        What would it take/is it possible to have this pulled into 2.2.x?

        Show
        Nick Spacek added a comment - What would it take/is it possible to have this pulled into 2.2.x?
        Hide
        Mark Fisher added a comment -

        Yep, I just added the target version of 2.2.2 (as well as 3.0 M1)

        Thanks again.
        -Mark

        Show
        Mark Fisher added a comment - Yep, I just added the target version of 2.2.2 (as well as 3.0 M1) Thanks again. -Mark
        Hide
        Gary Russell added a comment - - edited

        Original PR: https://github.com/SpringSource/spring-integration/pull/736

        Cherry-picked to 2.2.x and the snapshot build is complete - you should be able to find it in the snapshot repository.

        Show
        Gary Russell added a comment - - edited Original PR: https://github.com/SpringSource/spring-integration/pull/736 Cherry-picked to 2.2.x and the snapshot build is complete - you should be able to find it in the snapshot repository.

          People

          • Assignee:
            Gary Russell
            Reporter:
            Nick Spacek
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified