Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Complete
    • Affects Version/s: None
    • Fix Version/s: 1.0.0.RC2
    • Component/s: None
    • Labels:
      None

      Description

      tablet shouldn't be classified as mobile but rather as tablet

      i agree with comment in https://jira.springsource.org/browse/MOBILE-25 tablet should not render mobile pages

        Activity

        Hide
        Roy Clarkson added a comment - - edited

        Working on a LiteTabletDeviceResolver right now. My initial thoughts are to look for the following key words in the in the user agent header: "ipad", "playbook", "hp-tablet".

        These match to the following devices:

        Apple iPad:

        Mozilla/5.0 (iPad; CPU OS 5_0 like Mac OS X) AppleWebKit/534.46 (KHTML, like Gecko) Version/5.1 Mobile/9A334 Safari/7534.48.3

        BlackBerry Playbook:

        Mozilla/5.0 (PlayBook; U; RIM Tablet OS 1.0.0; en-US) AppleWebKit/534.8+(KHTML, like Gecko) Version/0.0.1 Safari/534.8+

        HP TouchPad:

        Mozilla/5.0 (hp-tablet; Linux; hpwOS/3.0.0; U; en-US) AppleWebKit/534.6 (KHTML, like Gecko) wOSBrowser/233.70 Safari/534.6 TouchPad/1.0";

        Lastly, Android tablet UA strings should contain "Android", but NOT "mobile", as per Google's recommendations.

        http://googlewebmastercentral.blogspot.com/2011/03/mo-better-to-also-detect-mobile-user.html

        Show
        Roy Clarkson added a comment - - edited Working on a LiteTabletDeviceResolver right now. My initial thoughts are to look for the following key words in the in the user agent header: "ipad", "playbook", "hp-tablet". These match to the following devices: Apple iPad: Mozilla/5.0 (iPad; CPU OS 5_0 like Mac OS X) AppleWebKit/534.46 (KHTML, like Gecko) Version/5.1 Mobile/9A334 Safari/7534.48.3 BlackBerry Playbook: Mozilla/5.0 (PlayBook; U; RIM Tablet OS 1.0.0; en-US) AppleWebKit/534.8+(KHTML, like Gecko) Version/0.0.1 Safari/534.8+ HP TouchPad: Mozilla/5.0 (hp-tablet; Linux; hpwOS/3.0.0; U; en-US) AppleWebKit/534.6 (KHTML, like Gecko) wOSBrowser/233.70 Safari/534.6 TouchPad/1.0"; Lastly, Android tablet UA strings should contain "Android", but NOT "mobile", as per Google's recommendations. http://googlewebmastercentral.blogspot.com/2011/03/mo-better-to-also-detect-mobile-user.html
        Hide
        Scott Rossillo added a comment - - edited

        I'd be happy to contribute development time to resolve this issue if you're interested. I filed a comment in forum about table support. http://forum.springsource.org/showthread.php?124643-Question-about-iPad-now-recognized-as-a-mobile-device-in-LiteDeviceResolver

        Show
        Scott Rossillo added a comment - - edited I'd be happy to contribute development time to resolve this issue if you're interested. I filed a comment in forum about table support. http://forum.springsource.org/showthread.php?124643-Question-about-iPad-now-recognized-as-a-mobile-device-in-LiteDeviceResolver
        Hide
        Roy Clarkson added a comment -

        Scott, thanks for the offer. Community involvement and contributions are always appreciated. I am in progress working on this feature update, and expecting to commit something soon.

        Show
        Roy Clarkson added a comment - Scott, thanks for the offer. Community involvement and contributions are always appreciated. I am in progress working on this feature update, and expecting to commit something soon.
        Hide
        Scott Rossillo added a comment -

        Roy, sorry I didn't see your comment sooner, I went ahead and coded a solution. I created a pull request for you on GitHub https://github.com/SpringSource/spring-mobile/pulls. In any case, let me know if my pull request is of any value, at least in terms of an approach to the problem and coding style.

        I've been using a number of Spring frameworks - and now Spring Mobile - in a number of projects for many years, and I've always appreciated the effort that goes into making such elegant solutions to the complex problems J2EE developers face.

        I'd be happy to contribute code for other open issues on the mobile project even if my solution to this issue isn't necessary.

        Show
        Scott Rossillo added a comment - Roy, sorry I didn't see your comment sooner, I went ahead and coded a solution. I created a pull request for you on GitHub https://github.com/SpringSource/spring-mobile/pulls . In any case, let me know if my pull request is of any value, at least in terms of an approach to the problem and coding style. I've been using a number of Spring frameworks - and now Spring Mobile - in a number of projects for many years, and I've always appreciated the effort that goes into making such elegant solutions to the complex problems J2EE developers face. I'd be happy to contribute code for other open issues on the mobile project even if my solution to this issue isn't necessary.
        Hide
        Roy Clarkson added a comment -

        Scott, as noted on GitHub, I pushed my implementation to master. It is similar to your pull request, so I'm happy to include you as an author on those files. Thanks again for the interest in the project, and if you see other open issues, feel free to contribute in whatever way you are available. We want these projects to be useful, and community involvement helps us gauge that. Thanks!

        Show
        Roy Clarkson added a comment - Scott, as noted on GitHub, I pushed my implementation to master. It is similar to your pull request, so I'm happy to include you as an author on those files. Thanks again for the interest in the project, and if you see other open issues, feel free to contribute in whatever way you are available. We want these projects to be useful, and community involvement helps us gauge that. Thanks!
        Hide
        Scott Rossillo added a comment -

        Hi Roy, thanks I appreciate that!

        Show
        Scott Rossillo added a comment - Hi Roy, thanks I appreciate that!

          People

          • Assignee:
            Roy Clarkson
            Reporter:
            mark cronin
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: