Uploaded image for project: 'Spring Modules'
  1. Spring Modules
  2. MOD-208

blocking threads with OSCache abstraction, OSCacheFacade must handle NeedsRefreshException

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 0.5
    • Fix Version/s: 0.7
    • Component/s: CACHE
    • Labels:
      None
    • Environment:
      JDK 5, Linux

      Description

      org.springmodules.cache.provider.oscache.OsCacheFacade.onGetFromCache(Serializable key, CachingModel model) simply ignores NeedsRefreshException throw from underlying OSCache implementation. This causes thread locking since OsCache expects that this is handled (see http://www.opensymphony.com/oscache/api/com/opensymphony/oscache/base/Cache.html#getFromCache(java.lang.String,%20int)). This solution is pretty simple: add
      cacheManager.cancelUpdate(newKey);
      inside the catch block.

        Attachments

          Activity

            People

            Assignee:
            irbouho Omar Irbouh
            Reporter:
            darthvader Stefan Armbruster
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: