Uploaded image for project: 'Spring Modules'
  1. Spring Modules
  2. MOD-217

AbstractCachingInterceptor should be much more extensible

    Details

    • Type: Improvement
    • Status: In Progress
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 0.5
    • Fix Version/s: None
    • Component/s: CACHE
    • Labels:
      None
    • Environment:
      Spring 1.2.7, jdk 1.4.2_12

      Description

      I'm trying to extend AbstractModelSourceCachingInterceptor for my own specific caching purposes but I find it almost impossible. Problem is in AbstractCachingInterceptor which have final setters and no getters for all properties. In such situation subclasses can not access configured properties like i.e. cacheProviderFacade (to which I need access in my extended interceptor). Further, afterProprtiesSet method is also final and does not provide i.e. beforeAfterPropertiesSet hook which extended classes can invoke before initialization of cache models take place.

      So, my need and suggestion is to introduce at least protected getters for all properties, and beforeAfterPropertiesSet hook in AbstractCachingInterceptor class. This features should not brake anything, and if you look at AbstractModelSourceCachingInterceptor class you can find getter for cachingModelSource property. It seams to me that such getters must also be available in AbstractCachingInterceptor if that class is intended to be truly extensible.

      Regards,
      Damir Murat

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                irbouho Omar Irbouh
                Reporter:
                dmurat Damir Murat
              • Votes:
                5 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: