Spring Roo
  1. Spring Roo
  2. ROO-1100

Create a LoggingOutputStream and use when delegating to Felix (for STS compatibility)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Complete
    • Affects Version/s: 1.1.0.M2
    • Fix Version/s: 1.1.0.M3
    • Component/s: @ CORE, @ ROO SHELL
    • Labels:
      None

      Description

      At present STS' embedded Roo console expects all output from Roo commands to appear via the JDK Logging API. This is the way Roo normally works. However, for the "felix" and "osgi" commands in Roo 1.1.0.M1 and 1.1.0.M2, the System.out and System.err is used by Felix. This is a requirement of Felix Shell API, which is the target of delegation calls from the "felix" and "osgi" commands.

      To resolve this a LoggingOutputStream needs to be written. This will log each line to the JDK Logging API for consistency with the rest of Roo (and embedding in STS). Threads should be avoided due to the ActiveProcessManager semantics involved in STS hosting multiple Roo projects concurrently. Once LoggingOutputStream is available, the FelixDelegator class in Roo should be changed to use it via (effectively) new PrintStream(new LoggingOutputStream(Level.INFO)).

        Activity

        Hide
        Ben Alex added a comment -

        Added in Git commit 6c048f3ca52522bc85df51d4b8154487d695193e. The new LoggingOutputStream also correctly presents the source class for messages. This is being used by FelixDelegator.

        Show
        Ben Alex added a comment - Added in Git commit 6c048f3ca52522bc85df51d4b8154487d695193e. The new LoggingOutputStream also correctly presents the source class for messages. This is being used by FelixDelegator.
        Hide
        Ben Alex added a comment -

        As an aside, this enhancement also helps standard Roo Shell users because errors from Felix now display in red, and normal messages in green.

        Show
        Ben Alex added a comment - As an aside, this enhancement also helps standard Roo Shell users because errors from Felix now display in red, and normal messages in green.

          People

          • Assignee:
            Ben Alex
            Reporter:
            Ben Alex
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: