Uploaded image for project: 'Spring Roo'
  1. Spring Roo
  2. ROO-1222

projectOperations.addPlugin adds empty <id/> and <phase/> tags per default which let maven ignore the build plugin

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.0.M3
    • Fix Version/s: 1.1.0.M3
    • Component/s: BUILD
    • Labels:
      None

      Description

      when updating maven build plugin the configuration element adds some invalid maven markup, so that maven ignores the build plugin:
      empty tags (id, phase) are invalid:
      <execution>
      <id/>
      <phase/>
      <goals>
      <goal>compile</goal>
      <goal>test-compile</goal>
      </goals>
      </execution>

      Patch: MavenProjectMetadataProvider

      final String id = execution.getId();
      if (id !=null && !id.isEmpty())

      { Element executionId = document.createElement("id"); executionId.setTextContent(id); executionElement.appendChild(executionId); }

      final String phase = execution.getPhase();
      if (phase!=null && !phase.isEmpty())

      { Element executionPhase = document.createElement("phase"); executionPhase.setTextContent(phase); executionElement.appendChild(executionPhase); }

        Attachments

          Activity

            People

            Assignee:
            balex Ben Alex
            Reporter:
            mhunger Michael Hunger
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: