Uploaded image for project: 'Spring Roo'
  1. Spring Roo
  2. ROO-154

Modiying menu.jsp can cause roo controller creation/management to fail

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.0.RC1
    • Component/s: None
    • Labels:
      None

      Description

      menu.jsp doesn't contain any warning disclaimer like the other jsp files and is critical to the web aspect creation and maintenance.

      Changing menu.jsp will cause roo to fail to create or manage controllers.

      roo> new controller automatic -name ~.web.LocalRoleController -formBackingObject
      ~.domain.LocalRoles
      Created SRC_MAIN_JAVA\org\stjude\ri\bwfp\web\LocalRoleController.java
      Managed SRC_MAIN_WEBAPP\WEB-INF\web.xml
      Created SRC_MAIN_JAVA\org\stjude\ri\bwfp\web\LocalRoleController_Roo_Controller.aj
      Created SRC_MAIN_WEBAPP\WEB-INF\jsp\localroles
      Created SRC_MAIN_WEBAPP\WEB-INF\jsp\localroles\list.jsp
      Created SRC_MAIN_WEBAPP\WEB-INF\jsp\localroles\show.jsp
      Created SRC_MAIN_WEBAPP\WEB-INF\jsp\localroles\create.jsp
      Created SRC_MAIN_WEBAPP\WEB-INF\jsp\localroles\update.jsp
      roo> [Fatal Error] :28:2: The markup in the document following the root element must be well-formed.
      Undo create SRC_MAIN_WEBAPP\WEB-INF\jsp\localroles\update.jsp
      Undo create SRC_MAIN_WEBAPP\WEB-INF\jsp\localroles\create.jsp
      Undo create SRC_MAIN_WEBAPP\WEB-INF\jsp\localroles\show.jsp
      Undo create SRC_MAIN_WEBAPP\WEB-INF\jsp\localroles\list.jsp
      Undo create SRC_MAIN_WEBAPP\WEB-INF\jsp\localroles
      Undo create SRC_MAIN_JAVA\org\stjude\ri\bwfp\web\LocalRoleController_Roo_Controller.aj
      The markup in the document following the root element must be well-formed.
      roo>

      A warning needs to be added to the top of the menu.jsp file similar to
      <Unable to render embedded object: File ( This file is maintained by ROO) not found. Do not alter it-->

      There needs to be more verbose information on which file the "new controller" command failed., e.g.

      roo> [Fatal Error] :28:2: The markup in the document following the root element must be well-formed - File: SRC_MAIN_WEBAPP\WEB-INF\jsp\menu.jsp

      Also the rollback should include the created java controller file.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              sschmidt Stefan Schmidt
              Reporter:
              dalford Dan Alford
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: