Uploaded image for project: 'Spring Roo'
  1. Spring Roo
  2. ROO-2860

Date formats with commas in (e.g. "MM") break list views in Roo scaffolds

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Complete
    • Affects Version/s: 1.2.0.M1
    • Fix Version/s: 1.2.0.RC1
    • Component/s: WEB MVC
    • Labels:
      None

      Description

      The scaffold uses the Roo tag lib "form/fields/column.tagx" and "form/fields/table.tagx", which communicate with one another by passing comma delimited strings through request-scoped JSP variables.

      Unfortunately, comma is not a safe delimiter in this context, as it can appear in the data (e.g. date formats can contain commas).

      To reproduce this, try creating a scaffold for an entity with "MM" formatted dates, and viewing the list pages.

      I have attached a fix as a patch (no unit test, sorry).

      I tried to use NULL '\0' delimited strings, but I couldn't get JSP to accept \0 in a string. (Does anyone know where the JSP syntax is actually documented? I have been unable to find this out even after extensive googling.) So instead, I have used ✏, which seems unlikely to appear in any column headings or date formats.

        Attachments

          Activity

            People

            Assignee:
            stewarta Alan Stewart
            Reporter:
            richard.bradley@softwire.com Richard Bradley
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: