Uploaded image for project: 'Spring Roo'
  1. Spring Roo
  2. ROO-2865

PhysicalTypeMetadata should extend MemberHoldingTypeDetailsMetadataItem<ClassOrInterfaceTypeDetails>

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Complete
    • Affects Version/s: 1.2.0.M1
    • Fix Version/s: 1.2.0.RC1
    • Component/s: @ CORE
    • Labels:
      None

      Description

      Currently, PhysicalTypeMetadata extends MemberHoldingTypeDetailsMetadataItem<MemberHoldingTypeDetails>, meaning that when we call getMemberHoldingTypeDetails() on it, we get a MemberHoldingTypeDetails. If we need the ClassOrInterfaceTypeDetails for the type, we have to cast the MemberHoldingTypeDetails to a ClassOrInterfaceTypeDetails. However a physical type always represents a Java class or interface (or an enum), so it would save a lot of casting and instanceof checks if we simply typed PhysicalTypeMetadata more strongly to be a MemberHoldingTypeDetailsMetadataItem<ClassOrInterfaceTypeDetails>.

        Attachments

          Activity

            People

            Assignee:
            aswan Andrew Swan
            Reporter:
            aswan Andrew Swan
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: