Uploaded image for project: 'Spring Roo'
  1. Spring Roo
  2. ROO-3479

Mixing StringBuilder and String concatenation in FinderMetadata.java

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Complete
    • Affects Version/s: 1.2.5.RELEASE
    • Fix Version/s: 1.3.0.RELEASE
    • Component/s: DYNAMIC FINDERS
    • Labels:
      None

      Description

      In addon-finder/src/main/java/org/springframework/roo/addon/finder/FinderMetadata.java line 308 the StringBuilder should be used instead of String concatenation.

      This results in source code that can not be compiled every time Spring Roo updates the finder aspects.

      Line should be

      bodyBuilder.appendFormalLine("queryBuilder.append(\" ORDER BY \").append( sortFieldName");");

        Attachments

          Activity

            People

            • Assignee:
              stewarta Alan Stewart
              Reporter:
              neo Johannes Schmidt
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: