Uploaded image for project: 'Spring Roo'
  1. Spring Roo
  2. ROO-3534

findbugs suggests static inner classes for converters

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.2.5.RELEASE
    • Fix Version/s: None
    • Component/s: WEB MVC
    • Labels:
    • Environment:
      Windows, JDK7, Deployed Roo from trunk

      Description

      Findbug gives the following message for all converters used in ApplicationConversionServiceFactoryBean_Roo_ConversionService:

      [INFO] The class com.myproject.toplevel.web.ApplicationConversionServiceFactoryBean$ApplicationConversionServiceFactoryBean_Roo_ConversionService$7 could be refactored into a named _static_ inner class 
      

      Is there a specific reason the approach was kept as not static nested classes? Could there be an improvement for this?

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              ckorakidis Chris Korakidis
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: