Spring Roo
  1. Spring Roo
  2. ROO-354

Dependencies incorrectly parsed when unexpected <type> element appearing in pom.xml

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0.RC2
    • Fix Version/s: 1.0.0.RC3
    • Component/s: BUILD
    • Labels:
      None
    • Environment:
      Linux Ubuntu 8.04 "amd46", Sun JDK1.6.0_16, Maven 2.1.0, STS2.2.0.

      Description

      I've changed some part of my pom.xml with Eclipse editor, something like add new Plugin and properties or Tabbed some dependencies for putting them in right format.

      Now after create a new Controller then pom.xml will include 10 repeated dependencies.

      1. pom.xml
        18 kB
        Sid
      2. pom.xml.after
        20 kB
        Sid
      3. pom.xml.before
        24 kB
        Sid

        Activity

        Hide
        Sid added a comment -

        pom.xml is my current pom .

        pom.xml.after is after adding new Controller with ROO

        I don't have pom.xml.before , Actually I couldn't find correct version of pom.xml , sorry about that.

        Show
        Sid added a comment - pom.xml is my current pom . pom.xml.after is after adding new Controller with ROO I don't have pom.xml.before , Actually I couldn't find correct version of pom.xml , sorry about that.
        Hide
        Sid added a comment -

        pom.xml.before is correct version before my modifies.

        Show
        Sid added a comment - pom.xml.before is correct version before my modifies.
        Hide
        Ben Alex added a comment -

        Thanks for taking the time to log this bug report.

        The problem was <type>$

        {dbunit.operation.type}

        </type> within the <configuration> of your new <plugin>. We were using an XPath expression that recursively descended to lower XML sub-elements for <type> elements, which was incorrect. This was demonstrated by the following command:

        metadata for id --metadataId MID:org.springframework.roo.project.ProjectMetadata#the_project
        

        The above would show "OTHER" as the dependency type.

        I've modified the XPath expression in SVN revision 395 and 396. Roo now behaves as expected. This will be included in Roo 1.0.0.RC3 released in the next day or two.

        Show
        Ben Alex added a comment - Thanks for taking the time to log this bug report. The problem was <type>$ {dbunit.operation.type} </type> within the <configuration> of your new <plugin>. We were using an XPath expression that recursively descended to lower XML sub-elements for <type> elements, which was incorrect. This was demonstrated by the following command: metadata for id --metadataId MID:org.springframework.roo.project.ProjectMetadata#the_project The above would show "OTHER" as the dependency type. I've modified the XPath expression in SVN revision 395 and 396. Roo now behaves as expected. This will be included in Roo 1.0.0.RC3 released in the next day or two.

          People

          • Assignee:
            Ben Alex
            Reporter:
            Sid
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: