Spring Roo
  1. Spring Roo
  2. ROO-887

Make logging compile out of generated scaffold apps

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Complete
    • Affects Version/s: 1.1.0.RELEASE
    • Fix Version/s: 1.1.0.RC1
    • Component/s: GWT
    • Labels:
      None

      Description

      Improvements to logging that are scheduled for M4

      Todo: Confirm that logging in scaffold compiles out when logging is disabled

      Done: Make sure logging example is in dist
      Done: Show de-obfuscated stack traces in the RequestFactoryRemoteLogHandler
      Done: Send Json across the wire rather than just messages
      Done: Show stack traces in the client side handlers as appropriate
      Done: Move LoggingRequest to RF subclasses
      Done: Fix the logging example

      Not Planned: Send a LogRecord accross the wire rather than Json (this is blocked on ability to send arbitrary objects across the wire which will not be implemented for this release)
      Not Planned: Make RFRLogHandler able to send multiple LogRecords accross the wire, and have it send logs every X seconds rather than right away. Instead, we will just get this for free when RF starts to do batching of all requests.

        Activity

        Hide
        Ray Ryan added a comment -

        Note the existing roo logging command. Do we honor it? Parallel it? gwt log?

        Show
        Ray Ryan added a comment - Note the existing roo logging command. Do we honor it? Parallel it? gwt log?
        Hide
        Ray Ryan added a comment -

        Decoupling this from user action tracking, which may or may not make 2.1

        Show
        Ray Ryan added a comment - Decoupling this from user action tracking, which may or may not make 2.1
        Hide
        Ray Ryan added a comment -

        In dev mode, when I hit this log line:

        public void onUncaughtException(Throwable e)

        { Window.alert("Error: " + e.getMessage()); log.log(Level.SEVERE, e.getMessage(), e); }

        I see only this in my terminal window, even though I'm passing in the throwable e:

        [ERROR] SEVERE: Client Side Logger: com.springsource.extrack.gwt.scaffold.Scaffold Message: One or more exceptions caught, see full set in UmbrellaException#getCauses

        Note the lack of a stack trace. The dev mode console, on the other hand, prints it.

        Show
        Ray Ryan added a comment - In dev mode, when I hit this log line: public void onUncaughtException(Throwable e) { Window.alert("Error: " + e.getMessage()); log.log(Level.SEVERE, e.getMessage(), e); } I see only this in my terminal window, even though I'm passing in the throwable e: [ERROR] SEVERE: Client Side Logger: com.springsource.extrack.gwt.scaffold.Scaffold Message: One or more exceptions caught, see full set in UmbrellaException#getCauses Note the lack of a stack trace. The dev mode console, on the other hand, prints it.
        Hide
        Chris Ramsdale added a comment -

        Marking this as Minor...we need to make sure we flesh it out, with an eye towards App Engine.

        Show
        Chris Ramsdale added a comment - Marking this as Minor...we need to make sure we flesh it out, with an eye towards App Engine.
        Hide
        Rodrigo Chandia added a comment -
        Show
        Rodrigo Chandia added a comment - Moved to GWT Issue Tracker at: http://code.google.com/p/google-web-toolkit/issues/detail?id=5379
        Hide
        Ray Ryan added a comment -

        Oops, still working on this.

        Show
        Ray Ryan added a comment - Oops, still working on this.
        Hide
        Unnur Gretarsdottir added a comment -

        Now it should be fixed

        Show
        Unnur Gretarsdottir added a comment - Now it should be fixed

          People

          • Assignee:
            Unnur Gretarsdottir
            Reporter:
            Chris Ramsdale
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: