Spring Security
  1. Spring Security
  2. SEC-1070

AbstractRetryEntryPoint always uses RetryWithHttpEntryPoint logger

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.4
    • Fix Version/s: 3.0.0 M1
    • Component/s: Core
    • Labels:
      None

      Description

      AbstractRetryEntryPoint has a static logger defined by RetryWithHttpEntryPoint.class, instead of using a non-static getLogger(getClass()) or an abstract Log getLogger() function that would be implemented in both RetryWithHttpEntryPoint and RetryWithHttpsEntryPoint to provide the correct class for logging.

      The impact is that log messages for the RetryWithHttpsEntryPoint get logged under the RetryWithHttpEntryPoint logger.

        Activity

        Hide
        Luke Taylor added a comment -

        Thanks. I've converted it to use a non-static logger and call getClass().

        Show
        Luke Taylor added a comment - Thanks. I've converted it to use a non-static logger and call getClass().

          People

          • Assignee:
            Luke Taylor
            Reporter:
            Brien Wheeler
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: