Spring Security
  1. Spring Security
  2. SEC-1090

Default colours assumed, not set, in stylesheet

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.4
    • Fix Version/s: 3.0.0 M1
    • Component/s: Docs and Website
    • Labels:
      None

      Description

      The stylesheet used for http://static.springframework.org/spring-security/site/ doesn't set the background/foreground colours on the page as a whole, only on individual elements (and a background image with a transparent background on #contentBox). This means that the browser defaults show through, which don't necessarily mix well with the green background they're on on the sidebar, or the off-white they appear on in the main area.

      Try setting the browser defaults to white text on a black background (a high contrast setup) and you'll see what I mean - the site is illegible. You need to make the defaults explicit in maven-base.css:

      body {
      margin: 0px;
      padding: 0px;
      color: black;
      background-color: white;
      }

      ... and the site will read just fine.

      NB while WCAG does suggest that /not/ setting background and foreground colours is a way to achieve accessibility ( http://www.w3.org/TR/2008/NOTE-WCAG20-TECHS-20081211/G148 ) that's not whats happened here - colours are specified for links, for the background of sidebars etc, and there is a coloured background image in the main content area.

        Activity

        Hide
        Luke Taylor added a comment -

        This is more an issue with the standard maven skin and the Spring version on sourceforge which the current site is based on. There is no maven-base.css in the project, though we can of course set up the same defaults in site.css.

        I've edited the files for the existing deployed sites in-situ, but the chances are we won't be using the maven-spring-skin for the next release unless someone gets a chance to update the look and feel to match the current incarnation of springsource.org. I'll probably be falling back to a default site css file for the next release.

        Show
        Luke Taylor added a comment - This is more an issue with the standard maven skin and the Spring version on sourceforge which the current site is based on. There is no maven-base.css in the project, though we can of course set up the same defaults in site.css. I've edited the files for the existing deployed sites in-situ, but the chances are we won't be using the maven-spring-skin for the next release unless someone gets a chance to update the look and feel to match the current incarnation of springsource.org. I'll probably be falling back to a default site css file for the next release.
        Hide
        Luke Taylor added a comment -

        I've modified site.css, which should hopefuly do the trick in future deployments, until the maven skin is updated and we decide to use it again.

        Show
        Luke Taylor added a comment - I've modified site.css, which should hopefuly do the trick in future deployments, until the maven skin is updated and we decide to use it again.

          People

          • Assignee:
            Luke Taylor
            Reporter:
            Brian Ewins
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: