Uploaded image for project: 'Spring Security'
  1. Spring Security
  2. SEC-1202

Remove SpringSecurityFilter or at least doFilter() method

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0 M1
    • Fix Version/s: 3.0.0 M2
    • Component/s: Web
    • Labels:
      None

      Description

      SpringSecurityFilter was a good idea in terms of avoiding duplicated code, but the doFilter() and doFilterHttp() methods make the stack trace double the size and thus harder to read. It also looks like the overhead from Spring Security's filter chain is more than it actually is.

        Activity

        Hide
        luke Luke Taylor added a comment -

        I've replaced the use of SpringSecurityFilter with spring-web's GenericFilterBean. Also removed the init() and destroy() methods from FilterChainProxy which called the corresponding filter chain methods, contradicting the description in the Javadoc.

        Show
        luke Luke Taylor added a comment - I've replaced the use of SpringSecurityFilter with spring-web's GenericFilterBean. Also removed the init() and destroy() methods from FilterChainProxy which called the corresponding filter chain methods, contradicting the description in the Javadoc.
        Hide
        issuemaster Spring Issuemaster added a comment -
        Show
        issuemaster Spring Issuemaster added a comment - This issue has been migrated to https://github.com/spring-projects/spring-security/issues/1453

          People

          • Assignee:
            luke Luke Taylor
            Reporter:
            luke Luke Taylor
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development