Spring Security
  1. Spring Security
  2. SEC-1282

Possible Bug - UnanimousBased Incorrectly Grants When One Of The Votes Is An Absension

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0 RC1
    • Fix Version/s: 3.0.0.RC2
    • Component/s: None
    • Labels:
      None
    • Environment:
      Solaris x64 (SunOS 5.10 Generic_141445-09), but I also see the issue on Win XP Pro SP3
      Java 1.6

      Description

      Overall Spring Security is AWESOME and you guys are doing a great job!

      However, I am convinced I found either a bug or Doc error in UnanimousBased AccessDecisionManager.
      The API doc says "grants access if only grant votes were received" but I am certain I got it to grant access when one of the votes was an Abstention.

      Or if this is not a bug, please clarify API to say
      "grants access if only grant or abstained votes were received"

      Thanks so much and keep up the great work!!
      Spring Security Rocks!

        Activity

        Hide
        Luke Taylor added a comment -

        Thanks. The class Javadoc is pretty clear that abstain or grant votes are required but I've clarifed the method Javadoc for the "decide" method to match.

        Show
        Luke Taylor added a comment - Thanks. The class Javadoc is pretty clear that abstain or grant votes are required but I've clarifed the method Javadoc for the "decide" method to match.
        Hide
        Bob Rowden added a comment -

        Yes. Sorry I should have specified that it was the Javadoc in the "decide" method that was hurting me. Thank you for clearing it up.
        --Bob

        Show
        Bob Rowden added a comment - Yes. Sorry I should have specified that it was the Javadoc in the "decide" method that was hurting me. Thank you for clearing it up. --Bob

          People

          • Assignee:
            Luke Taylor
            Reporter:
            Bob Rowden
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: