Spring Security
  1. Spring Security
  2. SEC-1407

Refactor URL Matching to use RequestMatcher interface

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1.0.M1
    • Component/s: Web
    • Labels:
      None

      Description

      At the moment classes like FilterChainProxy and DefaultFilterInvocationSecurityMetadataSource use a UrlMatcher and store a map of paths (patterns). They do the work of converting incoming URLs to lower case etc.

      It would make more sense if they used RequestMatchers as the Map key, with Ant and Regex path matchers a special case. This would allow for more flexible request matching and also for cleaner code, as the matcher implementations would encapsulate the upper/lower case logic etc.

        Issue Links

          Activity

          Hide
          Luke Taylor added a comment -

          This has been done, making the code for DefaultMethodSecurityMetadataSource much simpler and opening up the possibility of using more flexible matching strategies in future.

          Show
          Luke Taylor added a comment - This has been done, making the code for DefaultMethodSecurityMetadataSource much simpler and opening up the possibility of using more flexible matching strategies in future.

            People

            • Assignee:
              Luke Taylor
              Reporter:
              Luke Taylor
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: