Spring Security
  1. Spring Security
  2. SEC-1416

requires-channel should have an xs:restriction / enumeration in the Spring Security XML Schema

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 3.0.2
    • Fix Version/s: 3.1.0.M1
    • Component/s: Namespace
    • Labels:
      None

      Description

      Since requires-channel only works properly in the namespace configuration with the values 'https', 'http', or 'any' (ChannelAttributeFactory will throw an exception otherwise), it seems that it would make sense to restrict the available values by a schema declaration of xs:restriction on this attribute, much as is done with other restricted attributes.

      The modified attribute declaration would look like this:

      <xs:attribute name="requires-channel">
      <xs:annotation>
      <xs:documentation>Used to specify that a URL must be accessed over http or https, or that there is no preference. The value should be "http", "https" or "any", respectively.</xs:documentation>
      </xs:annotation>
      <xs:simpleType>
      <xs:restriction base="xs:token">
      <xs:enumeration value="http"/>
      <xs:enumeration value="https"/>
      <xs:enumeration value="any"/>
      </xs:restriction>
      </xs:simpleType>
      </xs:attribute>

        Activity

        Hide
        Luke Taylor added a comment -

        This used to be the case (see the 2.0.x schema for example). Unfortunately we can't support placeholders this way, and people requested that it be changed (see previous issues).

        Show
        Luke Taylor added a comment - This used to be the case (see the 2.0.x schema for example). Unfortunately we can't support placeholders this way, and people requested that it be changed (see previous issues).

          People

          • Assignee:
            Luke Taylor
            Reporter:
            Peter Mularien
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: