Spring Security
  1. Spring Security
  2. SEC-1449

HttpRequestResponseHolder has default method modifiers

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Duplicate
    • Affects Version/s: 3.0.2
    • Fix Version/s: 3.0.3
    • Component/s: Web
    • Labels:
      None

      Description

      I am trying to implement a custom org.springframework.security.web.context.SecurityContextRepository in my own package. When I tried to get the HttpServletRequest and HttpServletResponse from the org.springframework.security.web.context.HttpRequestResponseHolder I noticed that getRequest() and getResponse() have default method modifiers applied to them. From my point of view the modifiers should be public. For now I guess I have to put my custom implementation into a org.springframework.security.web.context package.

      public SecurityContext loadContext(HttpRequestResponseHolder httpRequestResponseHolder) {
      HttpServletRequest request = httpRequestResponseHolder.getRequest();
      HttpServletResponse response = httpRequestResponseHolder.getResponse();
      ...
      }

        Activity

        Hide
        Luke Taylor added a comment -

        SEC-1439. Please search Jira before opening new issues.

        Show
        Luke Taylor added a comment - SEC-1439 . Please search Jira before opening new issues.

          People

          • Assignee:
            Luke Taylor
            Reporter:
            Benjamin Muschko
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: