Spring Security
  1. Spring Security
  2. SEC-1552

Refactor and improve the code in AuthorizeTag to make it more easily re-usable in other rendering technologies

    Details

    • Type: Refactoring Refactoring
    • Status: Closed
    • Priority: Major Major
    • Resolution: Complete
    • Affects Version/s: 3.0.2
    • Fix Version/s: 3.1.0.M2
    • Component/s: Taglibs
    • Labels:
      None

      Description

      The <authorize/> tag is built for JSP pages. It extends from javax.servlet.jsp.tagext.TagSupport, has dependencies on javax.servlet.jsp.*, relies on the presence of javax.servlet.jsp.PageContext, etc.

      The ability to use the <authorize/> tag in JSF applications has been a long standing and popular request SWF-1333. With Facelets being the standard rendering technology in JSF 2, the need to make the tag usable in Facelets has only increased. Furthermore Facelets in JSF 1.2 uses different packages than Facelets in JSF 2 when Facelets became standard. Hence the re-usable parts of the code for AuthorizeTag need to be factored out and made independent of tag specific dependencies.

        Activity

        Hide
        Rossen Stoyanchev added a comment -

        The existing AuthorizeTag and its parent LegacyAuthorizeTag have been re-factored into a single base class AbstractAuthorizeTag with no JSP-related dependencies. A new JspAuthorizeTag class extending from AbstractAuthorizeTag implements the JSP Tag interface.

        Show
        Rossen Stoyanchev added a comment - The existing AuthorizeTag and its parent LegacyAuthorizeTag have been re-factored into a single base class AbstractAuthorizeTag with no JSP-related dependencies. A new JspAuthorizeTag class extending from AbstractAuthorizeTag implements the JSP Tag interface.

          People

          • Assignee:
            Rossen Stoyanchev
            Reporter:
            Rossen Stoyanchev
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: