Spring Security
  1. Spring Security
  2. SEC-1772

Unneeded URL decode in SimpleUrlLogoutSuccessHandler

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Complete
    • Affects Version/s: 3.0.5
    • Fix Version/s: 3.1.0.RC3
    • Component/s: None
    • Labels:
      None

      Description

      URLDecoder.decode(targetUrl, "UTF-8") call is not needed in org.springframework.security.web.authentication.logout.SimpleUrlLogoutSuccessHandler and it breaks URLs with GET parameters escaped in them.

      p.s. also isUseReferer() is missing.

        Issue Links

          Activity

          Hide
          Luke Taylor added a comment -

          I've removed the decoding. This was part of the patch for SEC-213, which was related to CAS proxying. I'm not sure if there was a valid reason for it then, but CAS proxying no longer requires redirects, so it no longer seems necessary in any case.

          Show
          Luke Taylor added a comment - I've removed the decoding. This was part of the patch for SEC-213 , which was related to CAS proxying. I'm not sure if there was a valid reason for it then, but CAS proxying no longer requires redirects, so it no longer seems necessary in any case.

            People

            • Assignee:
              Luke Taylor
              Reporter:
              Mikhail Mazursky
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: