Spring Security
  1. Spring Security
  2. SEC-1868

SecurityNamespaceHandler should not log an error if the web classes are not available

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.0
    • Fix Version/s: 3.1.1
    • Component/s: Namespace
    • Labels:
      None

      Description

      Currently the SecurityNamespaceHandler logs an error if the FilterChainProxy is not available on the classpath.
      This should be turned back to an if instead of a try/catch and it should definitely not log an error message

        Issue Links

          Activity

          Hide
          Rob Winch added a comment -

          Thank you for your bug submission. A fix has been pushed to master.

          For the interested...This was introduced with the desire to provide the user with more details when FilterChainProxy failed to load (i.e. FilterChainProxy was not found, Filter was not found etc) and <http/> was being used. The fix I pushed to master changed the init method to use ClassUtils.isPresent again and removed the logger.error statement. To get more details it attempts to load FilterChainProxy again when reporting the error to get a detailed error message.

          Show
          Rob Winch added a comment - Thank you for your bug submission. A fix has been pushed to master. For the interested...This was introduced with the desire to provide the user with more details when FilterChainProxy failed to load (i.e. FilterChainProxy was not found, Filter was not found etc) and <http/> was being used. The fix I pushed to master changed the init method to use ClassUtils.isPresent again and removed the logger.error statement. To get more details it attempts to load FilterChainProxy again when reporting the error to get a detailed error message.

            People

            • Assignee:
              Rob Winch
              Reporter:
              Roald Bankras
            • Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: