Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Complete
    • Affects Version/s: 3.1.0
    • Fix Version/s: 3.1.1
    • Component/s: Crypto
    • Labels:
      None

      Description

      I've cleaned the code up in the standalone jBCrypt project. This issue is to merge those changes into Spring Security along with its tests.

      • Use a ByteArrayOutputStream to cache bytes.
      • Pass a StringBuilder into encode_base64.
      • Refactor string comparison into its own method.
      • General clean up.

        Activity

        Hide
        Joseph Walton added a comment -
        Show
        Joseph Walton added a comment - Commit here: 8d24ebc24ff184f0bab0ee2a92ade9fbc4823a02 .
        Hide
        Rob Winch added a comment -

        Thanks you for your contribution. It has been merged into master and will be included in the 3.1.1 release

        Show
        Rob Winch added a comment - Thanks you for your contribution. It has been merged into master and will be included in the 3.1.1 release

          People

          • Assignee:
            Rob Winch
            Reporter:
            Joseph Walton
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: