Spring Security
  1. Spring Security
  2. SEC-990

Clarify the semantics of the ConsensusBased ADM

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.3
    • Fix Version/s: 3.0.0 M1
    • Component/s: ACLs
    • Labels:
      None

      Description

      Since "consensus" can mean either unanimous or else majority-rule (ignoring abstains), it may be unclear to people who are thinking that consensus = unanimous what the difference is between ConsensusBased and UnanimousBased. I would suggest adding a short bit of clarification to the class-level Javadoc; e.g.

      "Consensus" here means majority-rule (ignoring abstains) rather than unanimous agreement (ignoring abstains). If you require unanimity, please see

      {@link org.springframework.security.vote.UnanimousBased}

      .

        Activity

        Hide
        Luke Taylor added a comment -

        I've added your suggested patch to the class-level javadoc. The behaviour was already pretty clear from the description of the "decide" method, but some pople may not read that far .

        Show
        Luke Taylor added a comment - I've added your suggested patch to the class-level javadoc. The behaviour was already pretty clear from the description of the "decide" method, but some pople may not read that far .

          People

          • Assignee:
            Luke Taylor
            Reporter:
            Willie Wheeler
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: