Spring Security OAuth
  1. Spring Security OAuth
  2. SECOAUTH-234

oauth1 provider ignores authentication-failed-url attribute

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Complete
    • Affects Version/s: 1.0.0.M6
    • Fix Version/s: 1.0.0.RC1
    • Component/s: OAuth 1
    • Labels:
      None

      Description

      When configuring a <oauth:provider authentication-failed-url="" />, the authorization filter will not use the given URL, but the default (e.g.: send a 401 response).

      This is caused by the configuration parser not injecting the failurehandler properly into the filter. See referenced forum thread.

        Activity

        Show
        Geert van der Ploeg added a comment - Unit test revealing this issue: https://github.com/gvanderploeg/spring-security-oauth/commit/e7ed78c3b91ba95868186b762c58dac105c69de5
        Show
        Geert van der Ploeg added a comment - And the fix: https://github.com/gvanderploeg/spring-security-oauth/commit/6280254e061690d8d13c248e1d0b21bd5482a254
        Hide
        Dave Syer added a comment -

        Thanks for the pull request. Can you fill out the contribitor's agreement (link in README) and paste your confirmation code here (apologies if you already filled it out and I didn't see the agreement yet)?

        Show
        Dave Syer added a comment - Thanks for the pull request. Can you fill out the contribitor's agreement (link in README) and paste your confirmation code here (apologies if you already filled it out and I didn't see the agreement yet)?
        Hide
        Geert van der Ploeg added a comment -

        Confirmation code: 24220120405045441

        Show
        Geert van der Ploeg added a comment - Confirmation code: 24220120405045441
        Hide
        Dave Syer added a comment -

        Awesome, thanks.

        Show
        Dave Syer added a comment - Awesome, thanks.

          People

          • Assignee:
            Dave Syer
            Reporter:
            Geert van der Ploeg
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: