Uploaded image for project: 'SX Spring Security Extension'
  1. SX Spring Security Extension
  2. SES-86

Typo in java property, singingKey (me me me! laaaaaaaaaaaaaaaa!) should be signingKey

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Complete
    • Affects Version/s: saml-1.0.0.RC1
    • Fix Version/s: saml-1.0.0.RC1
    • Component/s: saml
    • Labels:
      None

      Description

      I think these are the changes but just search on ingingKey...

      diff org/springframework/security/saml/context/SAMLContextProviderImpl.java org/springframework/security/saml/context/SAMLContextProviderImpl.java
      230,231c230,231
      < if (extendedMetadata.getSingingKey() != null) {
      < samlContext.setLocalSigningCredential(keyManager.getCredential(extendedMetadata.getSingingKey()));

      > if (extendedMetadata.getSigningKey() != null) {
      > samlContext.setLocalSigningCredential(keyManager.getCredential(extendedMetadata.getSigningKey()));
      diff org/springframework/security/saml/metadata/ExtendedMetadata.java org/springframework/security/saml/metadata/ExtendedMetadata.java
      30c30
      < private String singingKey;

      > private String signingKey;
      84,85c84,85
      < public String getSingingKey() {
      < return singingKey;

      > public String getSigningKey() {
      > return signingKey;
      94c94
      < * @param singingKey key for creation/verification of signatures

      > * @param signingKey key for creation/verification of signatures
      96,97c96,97
      < public void setSingingKey(String singingKey) {
      < this.singingKey = singingKey;

      > public void setSigningKey(String signingKey) {
      > this.signingKey = signingKey;
      diff org/springframework/security/saml/metadata/MetadataGenerator.java org/springframework/security/saml/metadata/MetadataGenerator.java
      126c126
      < ex.setSingingKey(signingKey);

      > ex.setSigningKey(signingKey);
      diff org/springframework/security/saml/web/MetadataController.java org/springframework/security/saml/web/MetadataController.java
      166c166
      < metadata.setSigningKey(extendedMetadata.getSingingKey());

      > metadata.setSigningKey(extendedMetadata.getSigningKey());
      237c237
      < " <property name=\"singingKey\" value=\"").append(metadata.getSingingKey()).append("\"/>\n" +

      > " <property name=\"signingKey\" value=\"").append(metadata.getSigningKey()).append("\"/>\n" +

        Activity

        Hide
        vsch Vladimir Schäfer added a comment -

        It's not a bug, it's a musical feature

        Show
        vsch Vladimir Schäfer added a comment - It's not a bug, it's a musical feature

          People

          • Assignee:
            vsch Vladimir Schäfer
            Reporter:
            anon4321 William Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development