Uploaded image for project: 'SX Spring Python'
  1. SX Spring Python
  2. SESPRINGPYTHONPY-114

Move amara import statement inside XML-based parsers, move pyyaml inside YamlConfig

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.0.M2
    • Component/s: IoC
    • Labels:
      None

      Description

      Moving key library import statements to inside the class would make it an optional import. No XMLConfig, no amara. Regarding elementTree, see SESPRINGPYTHONPY-98, where we are replacing amara with elementTree.

      ===============================================================================

      Here I see two issues:

      • the amara dep is not resolved
      • a minor one: if the same thing could be achieved via elementtree, it
        would be far better, since the latter module is part of the standard
        python dist since python 2.5. This would let springpython to run with
        one dep less.

      Another one:
      >>> from springpython.config import PythonConfig
      Traceback (most recent call last):
      File "<stdin>", line 1, in <module>
      File
      "build/bdist.macosx-10.5-i386/egg/springpython/config/_init_.py", line
      16, in <module>
      import logging
      ImportError: No module named amara
      >>>

      This is another drawback of putting too many things into a single
      _init_.py - why should I need amara (an xml toolkit) if I don't need
      XMLConfig ? It is an unnecessary dep.

        Issue Links

          Activity

          Hide
          gregturn Greg Turnquist added a comment -

          This issue was addressed at the same time changes were being made to using amara.

          Show
          gregturn Greg Turnquist added a comment - This issue was addressed at the same time changes were being made to using amara.
          Hide
          gregturn Greg Turnquist added a comment -

          Completed when SESPRINGPYTHONPY-98 was merged into the trunk.

          Show
          gregturn Greg Turnquist added a comment - Completed when SESPRINGPYTHONPY-98 was merged into the trunk.

            People

            • Assignee:
              gregturn Greg Turnquist
              Reporter:
              gregturn Greg Turnquist
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: