Okay, I walked through each diff report, and then just skimmed the complete files. I finally generated the docs and looked at them. Everything is really quite good. The comments I have are tiny ones.
1) docs: rename sidebar "intro-syntax" as "jms-intro-syntax".
2) docs: replace "there were totaly 10,000 messages" with "there were a total of 10,000 messages".
3) docs: on overview page, add link to JMS Messaging as a key feature.
4) My system has python 2.4.6. I noticed that set works fine, and sets doesn't exist. What version of python 2.4 are you using? I saw your conditional test for using set inside src/springpython/jms/core.py. I just realized I haven't had to do that, and my tests are passing with python 2.4.6.
5) Is pymqi a CPython-only library? If so, a note should be added where you introduce pymqi.
6) In the documentation, I suggest that you comment on what exactly is included/not included. For instance you say that there are no JavaEE components running, and this can allow python-to-python messaging. Then what is physically acting as the message broker? I think its fine if you make it as a side note, so it doesn't interrupt the flow of documentation. Also, does the user have to download IBM Websphere to use this? Any licensing issues?
7) In docs,
XXX: Doesn't work, ignore for now
- object: MyQueue
Is this still the case? Or am I looking at an old copy?
8) Personal opinion: I would put this documentation before the plug-in section. Same goes for any other new features we develop. Right now, the plug-in stuff isn't that big and fancy. I think the JMS stuff is far more useful.
9) In the docs, it is good that you are using the full pathname for the class. However, I think you only need to do this the first time you mention the class. After that, it sort of interrupts the flow of reading (at least for me). Also, whenever there is an obvious block of code showing the import statement for the class, again, you can skip the full canonical name of the class.
10) In the docs, I see:
- object: jms_template
I believe it should be:
- object: jms_template
11) docs: "JmsTemplate may use a defualt JMS destination" <-- typo for default
12) docs: "The same JmsInstance may be used " What is JmsInstance?
13) I noticed that the docs say that receive() will time out after a certain amount of time. Is there any version of the API that will wait any amount of time until a message comes? Just curious.
All in all, this looks pretty solid to me!