Spring Social
  1. Spring Social
  2. SOCIAL-179

remove final from class AccessGrant so can be used by other oauth2 providers that return more than access_token/refreshToken/expire

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Complete
    • Affects Version/s: None
    • Fix Version/s: 1.0.0.RC1
    • Component/s: None
    • Labels:
      None

      Description

      Please make AccessGrant not final so it can be extended by other classes and provide additional params.
      For example bitly returns accessToken, userLogin, apiKey upon ouath and there is no place to save the extra params.
      Please make AccessGrant not a final class so it can be extended. (for a library api i don't understand why it's final). the other classes used by oauth2 such as connection factory, oauth2connection are not final and use AccessGrant but this class is forced to be final.
      Please remove this or at least add something like
      Map<String, Object> optionalParams to AccessGrant that can be available to add extra params into for later usage by connection creation process.

      thanks.
      linked to my original forum post: http://forum.springsource.org/showthread.php?109914-Suggestion-Please-allow-extra-params-to-be-saved-in-AccessGrant-upon-oauth

        Activity

        Hide
        Craig Walls added a comment -

        AccessGrant is no longer final.

        Show
        Craig Walls added a comment - AccessGrant is no longer final.

          People

          • Assignee:
            Unassigned
            Reporter:
            Parwiz Rezai
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: