Spring Social
  1. Spring Social
  2. SOCIAL-308

Provider errors reported in connection flow for non-provider problems

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Deferred
    • Affects Version/s: None
    • Fix Version/s: 1.1.0.M2, 1.1.0.M3
    • Component/s: None
    • Labels:
      None

      Description

      There have been a few reported instances of an "error=provider" parameter being sent in situations that don't involve a communication problem with the provider; when this happens, it's usually a data problem (e.g., the UserConnection table wasn't properly created or some constraint was violated). ProviderSignInController should properly report an error to the client (and/or the logs) indicating the true nature of the problem.

        Activity

        Hide
        Craig Walls added a comment -

        For 1.1.0.M2, I've added some additional logging around the "error=provider" code to (1) determine if this is still a problem and (2) if so, determine from the logs what cases might trigger it.

        If enough information comes from this in time for 1.1.0.M3, then I will address it for that release. Otherwise, this will continue to be deferred until such time that we have a handle on what types of error conditions (if any) trigger this miscommunication of a provider error.

        Show
        Craig Walls added a comment - For 1.1.0.M2, I've added some additional logging around the "error=provider" code to (1) determine if this is still a problem and (2) if so, determine from the logs what cases might trigger it. If enough information comes from this in time for 1.1.0.M3, then I will address it for that release. Otherwise, this will continue to be deferred until such time that we have a handle on what types of error conditions (if any) trigger this miscommunication of a provider error.

          People

          • Assignee:
            Craig Walls
            Reporter:
            Craig Walls
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: