Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.1.0.M1
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      SocialAuthenticationFilter extends GenericFilterBean, but lots of code copied from AbstractAuthenticationProcessingFilter. It is better to extend AbstractAuthenticationProcessingFilter.

      A spring-security issue SEC-2102 was raised to add redirect handling in AbstractAuthenticationProcessingFilter. See https://jira.springsource.org/browse/SEC-2102.

      See https://github.com/jiwhiz/spring-social/tree/security-refactor for the code changes.

        Activity

        Hide
        Yuan Ji added a comment -

        Override unsuccessfulAuthentication() to handle redirect exception. SEC-2102 is not necessary now.

        Show
        Yuan Ji added a comment - Override unsuccessfulAuthentication() to handle redirect exception. SEC-2102 is not necessary now.

          People

          • Assignee:
            Craig Walls
            Reporter:
            Yuan Ji
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: