Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Complete
    • Affects Version/s: 3.2 M2
    • Fix Version/s: 3.2 GA
    • Component/s: [Build], Test
    • Labels:
      None
    • Last commented by a User:
      false

      Description

      Status Quo

      The JUnit team recently released JUnit 4.11.

      Excerpt from the JUnit 4.11 Release Notes

      The following information is applicable to the Spring Framework build, especially with regard to junit:junit vs. junit:junit-dep and Hamcrest Maven dependencies.

      Maven artifacts

      Up until now there were two Maven artifacts for JUnit: junit:junit-dep and junit:junit. From a Maven point-of-view only the former made sense because it did not contain the Hamcrest classes but declared a dependency to the Hamcrest Maven artifact. The latter included the Hamcrest classes which was very un-Maven-like.

      From this release on, you should use junit:junit which will be what junit:junit-dep used to. If you still reference junit:junit-dep, Maven will automatically relocate you to the new junit:junit and issue a warning for you to fix.

      Deliverables

      1. Upgrade the dependency on JUnit in the spring-test module from 4.10 to 4.11.
      2. Update the entire Gradle build to use JUnit 4.11 instead of the 4.11 snapshot build currently in use.
      3. Update the changelog.

        Issue Links

          Activity

          Hide
          Chris Beams added a comment -

          Thanks for the heads-up, Sam! Feel free to reassign to yourself if you like. Otherwise I'll do it for GA for sure. Good timing all around.

          Show
          Chris Beams added a comment - Thanks for the heads-up, Sam! Feel free to reassign to yourself if you like. Otherwise I'll do it for GA for sure. Good timing all around.
          Hide
          Sam Brannen added a comment -

          Resolved as described in the comments for GitHub commit 2b4ecfad12:

          Upgrade to JUnit 4.11

          This commit upgrades the compile dependency on JUnit in the spring-test
          module as well as the global test dependency on JUnit for the entire
          test suite to 4.11 GA.

          In addition, the spring-test module now depends on junit:junit instead
          of junit:junit-dep since, as of JUnit 4.11, the "junit" Maven artifact
          no longer inlines hamcrest-core.

          Show
          Sam Brannen added a comment - Resolved as described in the comments for GitHub commit 2b4ecfad12 : Upgrade to JUnit 4.11 This commit upgrades the compile dependency on JUnit in the spring-test module as well as the global test dependency on JUnit for the entire test suite to 4.11 GA. In addition, the spring-test module now depends on junit:junit instead of junit:junit-dep since, as of JUnit 4.11, the "junit" Maven artifact no longer inlines hamcrest-core.

            People

            • Assignee:
              Sam Brannen
              Reporter:
              Sam Brannen
              Last updater:
              Sam Brannen
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                1 year, 20 weeks, 1 day ago