Spring Framework
  1. Spring Framework
  2. SPR-10164

ShallowEtagHeaderFilter should deal with the If-Match HTTP Header

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Deferred
    • Affects Version/s: 3.2 GA
    • Fix Version/s: 4.0 RC1
    • Component/s: Web
    • Last commented by a User:
      false

      Description

      ShallowEtagHeaderFilter supports the

      If-None-Match

      header, so it would make sense if it would also support the

      If-Match

      header as well. This would make the out of the box behaviour of this filter much more in sync with the HTTP spec (which is the whole point of the filter).
      The same shallow implementation would be fine here as well, same as now.

        Activity

        Hide
        Rossen Stoyanchev added a comment - - edited

        If you have time to put together a pull request with the suggested change, I'll take a look.

        Show
        Rossen Stoyanchev added a comment - - edited If you have time to put together a pull request with the suggested change, I'll take a look.
        Hide
        Eugen Paraschiv added a comment -

        Created pull request: https://github.com/SpringSource/spring-framework/pull/215
        Thanks.
        Eugen.

        Show
        Eugen Paraschiv added a comment - Created pull request: https://github.com/SpringSource/spring-framework/pull/215 Thanks. Eugen.
        Hide
        Phil Webb added a comment -

        I am going to close this one for now until we have a little more understanding about the use-case this covers.

        Show
        Phil Webb added a comment - I am going to close this one for now until we have a little more understanding about the use-case this covers.

          People

          • Assignee:
            Phil Webb
            Reporter:
            Eugen Paraschiv
            Last updater:
            Phil Webb
          • Votes:
            2 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Days since last comment:
              25 weeks, 6 days ago