Uploaded image for project: 'Spring Framework'
  1. Spring Framework
  2. SPR-11267

better method identification in AnnotationTransactionAttributeSource logging

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Complete
    • Affects Version/s: 3.2.6
    • Fix Version/s: 3.2.7, 4.0.1
    • Component/s: Transaction
    • Labels:
      None
    • Last commented by a User:
      true

      Description

      We am using @Transactional annotations in our projects, but logging does not identify the methods found very well.

      In our project there are many separate DAOs & services, which frequently use similar method-names. We see 400+ of these, a good proportion of which have repetitive names & without classes cannot be identified:

      Adding transactional method 'findById' with attribute: PROPAGATION_REQUIRED,ISOLATION_DEFAULT,readOnly; ''
      Adding transactional method 'remove' with attribute: PROPAGATION_REQUIRED,ISOLATION_DEFAULT; ''
      Adding transactional method 'create' with attribute: PROPAGATION_REQUIRED,ISOLATION_DEFAULT; ''
      Adding transactional method 'update' with attribute: PROPAGATION_REQUIRED,ISOLATION_DEFAULT; ''
      Adding transactional method 'findById' with attribute: PROPAGATION_REQUIRED,ISOLATION_DEFAULT,readOnly; ''
      Adding transactional method 'create' with attribute: PROPAGATION_REQUIRED,ISOLATION_DEFAULT; ''
      Adding transactional method 'update' with attribute: PROPAGATION_REQUIRED,ISOLATION_DEFAULT; ''

      We want to be able to identify whether a particular class/method is getting scanned (or not) for transactionality, to allow us to engineer/ diagnose/ debug in this area.

      Logging Class.Method would be much more useful (simple name only, no FQN) to enable engineering & diagnostis of transaction definitions.

      (Keywords: AbstractFallbackTransactionAttributeSource, AnnotationTransactionAttributeSource, transaction attribute source logging, method name.)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              juergen.hoeller Juergen Hoeller
              Reporter:
              twhitmore.nz@gmail.com Thomas Whitmore
              Last updater:
              Spring Issues Spring Issues
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Days since last comment:
                3 years, 37 weeks, 6 days ago