Uploaded image for project: 'Spring Framework'
  1. Spring Framework
  2. SPR-11330

Wrong assert in AspectJAwareAdvisorAutoProxyCreator.setAspectJAdvisorFactory()

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Complete
    • 3.2.6, 4.0 GA
    • 3.2.7, 4.0.1
    • Core:AOP
    • None
    • true

    Description

      Hi all

      Now is asserting on member instead argument. Actually is

      public void setAspectJAdvisorFactory(AspectJAdvisorFactory aspectJAdvisorFactory) {
      		Assert.notNull(this.aspectJAdvisorFactory, "AspectJAdvisorFactory must not be null");
      		this.aspectJAdvisorFactory = aspectJAdvisorFactory;
      	}
      

      I supose that should be:

      public void setAspectJAdvisorFactory(AspectJAdvisorFactory aspectJAdvisorFactory) {
      		Assert.notNull(aspectJAdvisorFactory, "AspectJAdvisorFactory must not be null");
      		this.aspectJAdvisorFactory = aspectJAdvisorFactory;
      	}
      

      Best regards

      Jose

      Attachments

        Activity

          People

            juergen.hoeller Juergen Hoeller
            jlm Jose Luis Martin
            Spring Issues Spring Issues
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              3 years, 38 weeks, 1 day ago