Uploaded image for project: 'Spring Framework'
  1. Spring Framework
  2. SPR-13668

Implement containsKey for HttpHeaders returned from ServletServerHttpResponse

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Complete
    • Affects Version/s: 4.1.8, 4.2.2
    • Fix Version/s: 4.1.9, 4.2.3
    • Component/s: Web
    • Labels:
      None
    • Last commented by a User:
      false

      Description

      As currently implemented ServletServerHttpResponse.getHeaders().containsKey(String) always returns false for any pre-existing headers in the underlying HttpServletResponse. We should override the containsKey method or modify how the parent HttpHeaders class behaves so that the HttpServletResponse is consulted.

      I'm logging this issue pretty quickly so I don't forget. There may be other methods on ServletResponseHttpHeaders that need fixed.

      Note that this impacts the fix for SPR-13548 since the intent is to only set the Content-Disposition if it has not been set.

        Attachments

          Activity

            People

            • Assignee:
              rstoya05-aop Rossen Stoyanchev
              Reporter:
              rwinch Rob Winch
              Last updater:
              Juergen Hoeller
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                3 years, 2 weeks ago