Uploaded image for project: 'Spring Framework'
  1. Spring Framework
  2. SPR-13668

Implement containsKey for HttpHeaders returned from ServletServerHttpResponse

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Complete
    • 4.1.8, 4.2.2
    • 4.1.9, 4.2.3
    • Web
    • None
    • true

    Description

      As currently implemented ServletServerHttpResponse.getHeaders().containsKey(String) always returns false for any pre-existing headers in the underlying HttpServletResponse. We should override the containsKey method or modify how the parent HttpHeaders class behaves so that the HttpServletResponse is consulted.

      I'm logging this issue pretty quickly so I don't forget. There may be other methods on ServletResponseHttpHeaders that need fixed.

      Note that this impacts the fix for SPR-13548 since the intent is to only set the Content-Disposition if it has not been set.

      Attachments

        Activity

          People

            rstoya05-aop Rossen Stoyanchev
            rwinch Rob Winch
            Spring Issues Spring Issues
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              3 years, 47 weeks, 2 days ago